Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 074A32009F8 for ; Fri, 3 Jun 2016 09:05:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 06341160A49; Fri, 3 Jun 2016 07:05:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4EA20160A25 for ; Fri, 3 Jun 2016 09:05:00 +0200 (CEST) Received: (qmail 1158 invoked by uid 500); 3 Jun 2016 07:04:59 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 1100 invoked by uid 99); 3 Jun 2016 07:04:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jun 2016 07:04:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 469692C1F6B for ; Fri, 3 Jun 2016 07:04:59 +0000 (UTC) Date: Fri, 3 Jun 2016 07:04:59 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15174) Client Public API should not have PB objects in 2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 03 Jun 2016 07:05:01 -0000 [ https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-15174: ------------------------------------------- Attachment: HBASE-15174_4.patch Avoids Parameter itself from the test case. Goes with jdk 1.7 school of thought of using ParameterTypes which is Class. Lets see if Hadoop QA works now. > Client Public API should not have PB objects in 2.0 > --------------------------------------------------- > > Key: HBASE-15174 > URL: https://issues.apache.org/jira/browse/HBASE-15174 > Project: HBase > Issue Type: Sub-task > Reporter: Enis Soztutar > Assignee: ramkrishna.s.vasudevan > Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-15174.patch, HBASE-15174_1.patch, HBASE-15174_2.patch, HBASE-15174_3.patch, HBASE-15174_4.patch > > > Some more cleanup for the parent jira. > We have leaked some PB structs in Admin (and possible other places). > We should clean up these API before 2.0. > Examples include: > {code} > AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final TableName tableName) > throws IOException; > > .... > void snapshot(final String snapshotName, > final TableName tableName, > HBaseProtos.SnapshotDescription.Type type) throws IOException, SnapshotCreationException, > IllegalArgumentException; > .... > MasterProtos.SnapshotResponse takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot) > throws IOException, SnapshotCreationException; > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)