hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16144) Replication queue's lock will live forever if RS acquiring the lock has dead
Date Wed, 29 Jun 2016 14:25:31 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355319#comment-15355319
] 

Ted Yu commented on HBASE-16144:
--------------------------------

{code}
+  public String getLockNode(String znode) {
{code}
Name the method getLockZNode().
{code}
+  public boolean checkLockExist(String znode) throws KeeperException {
{code}
checkLockExist -> checkLockExists
{code}
+      } catch (Exception e) {
+        LOG.warn("start replicationZKLockCleanerChore failed", e);
{code}
Should the above be at error level ?

Please add license to ReplicationZKLockCleanerChore

Please fix findbugs warnings.

> Replication queue's lock will live forever if RS acquiring the lock has dead
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-16144
>                 URL: https://issues.apache.org/jira/browse/HBASE-16144
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.1, 1.1.5, 0.98.20
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>         Attachments: HBASE-16144-v1.patch
>
>
> In default, we will use multi operation when we claimQueues from ZK. But if we set hbase.zookeeper.useMulti=false,
we will add a lock first, then copy nodes, finally clean old queue and the lock. 
> However, if the RS acquiring the lock crash before claimQueues done, the lock will always
be there and other RS can never claim the queue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message