hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16139) Use CellUtil instead of KeyValueUtil in Import.java
Date Wed, 29 Jun 2016 01:30:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354086#comment-15354086
] 

Ted Yu commented on HBASE-16139:
--------------------------------

Please fix formatting:
{code}
1511	  public static Cell createFirstOnRow(final byte [] row, int roffset, short rlength)
{
1512		  return new FirstOnRowCell(row, roffset, rlength);
1513		  }
{code}
Indentation is two spaces.

> Use CellUtil instead of KeyValueUtil in Import.java
> ---------------------------------------------------
>
>                 Key: HBASE-16139
>                 URL: https://issues.apache.org/jira/browse/HBASE-16139
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: NIDHI GAMBHIR
>            Assignee: NIDHI GAMBHIR
>            Priority: Minor
>         Attachments: HBASE-16139.patch
>
>
> Currently in Import.java, map function uses KeyValueUtil.createFirstOnRow. This method
calls createByteArray which causes a lot of copying. Instead use CellUtil's createFirstOnRow
method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message