hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16108) RowCounter should support multiple key ranges
Date Wed, 29 Jun 2016 17:21:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355506#comment-15355506
] 

Ted Yu commented on HBASE-16108:
--------------------------------

{code}
-      Context context)
-    throws IOException {
+                    Context context)
{code}
Indentation should be two spaces. Please avoid unneeded formatting.
{code}
+    if (null != filter)
+      scan.setFilter(filter);
+    else
+      scan.setFilter(new FirstKeyOnlyFilter());
{code}
Use curly braces around body of if / else.
{code}
-    scan.setFilter(new FirstKeyOnlyFilter());
+    //scan.setFilter(new FirstKeyOnlyFilter());
{code}
Drop the code when it is no longer used.

Can you try the patch with one pair of keys (start / end) on a table with large number of
rows to see if the performance is on par with the current one ?

Thanks

> RowCounter should support multiple key ranges
> ---------------------------------------------
>
>                 Key: HBASE-16108
>                 URL: https://issues.apache.org/jira/browse/HBASE-16108
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Geoffrey Jacoby
>            Assignee: Konstantin Ryakhovskiy
>         Attachments: HBASE-16108.master.001.patch
>
>
> Currently, RowCounter only allows a single key range to be used as a filter. It would
be useful in some cases to be able to specify multiple key ranges (or prefixes) in the same
job. (For example, counting over a set of Phoenix tenant ids in an unsalted table)
> This could be done by enhancing the existing key range parameter to take multiple start/stop
row pairs. Alternately, a new --row-prefixes option could be added, similar to what HBASE-15847
did for VerifyReplication. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message