hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16090) ResultScanner is not closed in SyncTable#finishRemainingHashRanges()
Date Thu, 23 Jun 2016 03:59:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345685#comment-15345685
] 

Yu Li commented on HBASE-16090:
-------------------------------

+1, patch lgtm, too.

> ResultScanner is not closed in SyncTable#finishRemainingHashRanges()
> --------------------------------------------------------------------
>
>                 Key: HBASE-16090
>                 URL: https://issues.apache.org/jira/browse/HBASE-16090
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 16090.v1.txt, 16090.v1.txt
>
>
> Here is related code:
> {code}
>           ResultScanner targetScanner = targetTable.getScanner(scan);
>           for (Result row : targetScanner) {
>             targetHasher.hashResult(row);          
>           }
>         } // else current batch ends exactly at split end row
> {code}
> targetScanner should be closed upon leaving the if block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message