hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16048) Consider tagging InternalScanner with LimitedPrivate(HBaseInterfaceAudience.COPROC)
Date Thu, 16 Jun 2016 20:58:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334665#comment-15334665
] 

Ted Yu commented on HBASE-16048:
--------------------------------

Below is code from UngroupedAggregateRegionObserver of Phoenix:
{code}
   @Override
    public InternalScanner preCompact(ObserverContext<RegionCoprocessorEnvironment>
c, final Store store,
            InternalScanner scanner, final ScanType scanType) throws IOException {
        TableName table = c.getEnvironment().getRegion().getRegionInfo().getTable();
        InternalScanner internalScanner = scanner;
        if (scanType.equals(ScanType.COMPACT_DROP_DELETES)) {
            try {
                long clientTimeStamp = TimeKeeper.SYSTEM.getCurrentTime();
                StatisticsCollector stats = StatisticsCollectorFactory.createStatisticsCollector(
                        c.getEnvironment(), table.getNameAsString(), clientTimeStamp,
                        store.getFamily().getName());
                internalScanner = stats.createCompactionScanner(c.getEnvironment(), store,
scanner);
{code}

> Consider tagging InternalScanner with LimitedPrivate(HBaseInterfaceAudience.COPROC) 
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-16048
>                 URL: https://issues.apache.org/jira/browse/HBASE-16048
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>
> Some methods (preCompact, preCompactScannerOpen, preFlush, preFlushScannerOpen, etc)
of BaseRegionObserver take InternalScanner as input argument as well as the return type.
> BaseRegionObserver is tagged with @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC)
but InternalScanner is tagged with @InterfaceAudience.Private.
> This JIRA is to discuss tagging InternalScanner with @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message