hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16045) endtime argument for VerifyReplication was incorrectly specified in usage
Date Thu, 16 Jun 2016 17:36:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334244#comment-15334244
] 

Ted Yu commented on HBASE-16045:
--------------------------------

Looking at CopyTable :
{code}
        final String endTimeArgKey = "--endtime=";
        if (cmd.startsWith(endTimeArgKey)) {
          endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
          continue;
        }
{code}
I see the same pattern where there is no check on illegal argument.


> endtime argument for VerifyReplication was incorrectly specified in usage
> -------------------------------------------------------------------------
>
>                 Key: HBASE-16045
>                 URL: https://issues.apache.org/jira/browse/HBASE-16045
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 16045.v1.txt
>
>
> Working on a customer case where the following was given for verifyrep:
> {code}
> --starttime=1456790400000 \ 
> --stoptime=1456876800000
> {code}
> Customer complained that the timestamp of a (sample) row reported as ONLY_IN_PEER_TABLE_ROWS
corresponded to time outside the time range.
> The code says:
> {code}
> final String endTimeArgKey = "--endtime=";
> {code}
> It turns out that usage String was wrong:
> {code}
>     System.err.println("Usage: verifyrep [--starttime=X]" +
>         " [--stoptime=Y] [--families=A] <peerid> <tablename>");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message