hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dima Spivak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16034) Fix ProcedureTestingUtility#LoadCounter.setMaxProcId()
Date Wed, 15 Jun 2016 18:32:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332277#comment-15332277
] 

Dima Spivak commented on HBASE-16034:
-------------------------------------

Is your working dir clean? The fix of maxProcId looks good, but the patch you posted looks
like it's modifying code that's not pushed yet ({{restartAndAssert}}).

> Fix ProcedureTestingUtility#LoadCounter.setMaxProcId() 
> -------------------------------------------------------
>
>                 Key: HBASE-16034
>                 URL: https://issues.apache.org/jira/browse/HBASE-16034
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2, test
>    Affects Versions: 2.0.0, 1.3.0, 1.2.1
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0, 1.2.2
>
>         Attachments: HBASE-16034-v0.patch
>
>
> ProcedureTestingUtility LoadCounter.setMaxProcId() implementation is wrong, and it ends
up not setting the max value
> {code}
>      public void setMaxProcId(long maxProcId) {
> -      maxProcId = maxProcId;
> +      this.maxProcId = maxProcId;
>      }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message