hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16033) Add more details in logging of responseTooSlow/TooLarge
Date Thu, 16 Jun 2016 13:34:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333776#comment-15333776

Hudson commented on HBASE-16033:

FAILURE: Integrated in HBase-1.4 #218 (See [https://builds.apache.org/job/HBase-1.4/218/])
HBASE-16033 Add more details in logging of responseTooSlow/TooLarge (liyu: rev 66b27884320822984bc6b70f519c640a0c516ca7)
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java

> Add more details in logging of responseTooSlow/TooLarge
> -------------------------------------------------------
>                 Key: HBASE-16033
>                 URL: https://issues.apache.org/jira/browse/HBASE-16033
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.1
>            Reporter: Yu Li
>            Assignee: Yu Li
>             Fix For: 2.0.0, 1.3.0
>         Attachments: HBASE-16033.patch, HBASE-16033.patch, HBASE-16033.patch
> Currently the log message when responseTooSlow/TooLarge is like:
> {noformat}
> 2016-06-08 12:18:04,363 WARN  [B.defaultRpcServer.handler=127,queue=10,port=16020]
> ipc.RpcServer: (responseTooSlow): {"processingtimems":13125,"call":"Multi(org.apache.hadoop.hbase.protobuf.generated.ClientProtos$MultiRequest)",
> "client":"","starttimems":1465359471238,"queuetimems":1540116,
> "class":"HRegionServer","responsesize":17,"method":"Multi"}
> {noformat}
> which is kind of helpless for debugging since we don't know on which table/region/row
the request is against.
> What's more, we could see some if-else check in the {{RpcServer#logResponse}} method
which trying to do sth different when the {{param}} includes instance of {{Operation}}, but
there's only one place invoking {{logResponse}} and the {{param}} is always an instance of
{{Message}}. Checking the change history, I believe this is a left-over cleanup in work of
> We will address the above issues, do some cleanup and improve the log just like {{RpcServer$Call#toString}}
does to include table/region/row information of the request

This message was sent by Atlassian JIRA

View raw message