hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Antonov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15982) Interface ReplicationEndpoint extends Guava's Service
Date Fri, 17 Jun 2016 06:28:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335512#comment-15335512
] 

Mikhail Antonov commented on HBASE-15982:
-----------------------------------------

At this point I'd say- let's just not make it on 1.3. 

New good changes come in every day, but just at some point we have to draw the line in the
sand and say that from now on - sorry, let's make no changes before the RC but critical fixes
plus patches needed to stabilize the branch (test fixes, broken/flaky tests etc).

Since it's only LP interface I suppose it doesn't justify it to be critical, but please correct
me if I'm missing something.

> Interface ReplicationEndpoint extends Guava's Service
> -----------------------------------------------------
>
>                 Key: HBASE-15982
>                 URL: https://issues.apache.org/jira/browse/HBASE-15982
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>             Fix For: 2.0.0, 1.4.0, 0.98.21
>
>
> We have Guava's Service leaking into the LimitedPrivate interface ReplicationEndpoint:
> {code}
> public interface ReplicationEndpoint extends Service, ReplicationPeerConfigListener
> {code}
> This required a private patch when I updated Guava for our internal deployments. This
is going to be a problem for us for long term maintenance and implenters of pluggable replication
endpoints. LP is only less than public by a degree. We shouldn't leak types from third part
code into either Public or LP APIs in my opinion. Let's fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message