hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15982) Interface ReplicationEndpoint extends Guava's Service
Date Fri, 17 Jun 2016 01:19:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335147#comment-15335147
] 

Andrew Purtell commented on HBASE-15982:
----------------------------------------

How tolerant are we of a one time change in the inheritance hierarchy of LP(coproc) interface
ReplicationEndpoint ?

No problem to commit to branch-1 and master. For 1.3 it's possible, depends if [~mantonov]
is still accepting latecomers. For 0.98 we can also do it as each 0.98.x is a minor release.
Branches 1.2 ([~busbey]) and 1.1 ([~ndimiduk]) would be out, I presume. 

> Interface ReplicationEndpoint extends Guava's Service
> -----------------------------------------------------
>
>                 Key: HBASE-15982
>                 URL: https://issues.apache.org/jira/browse/HBASE-15982
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 0.98.21
>
>
> We have Guava's Service leaking into the LimitedPrivate interface ReplicationEndpoint:
> {code}
> public interface ReplicationEndpoint extends Service, ReplicationPeerConfigListener
> {code}
> This required a private patch when I updated Guava for our internal deployments. This
is going to be a problem for us for long term maintenance and implenters of pluggable replication
endpoints. LP is only less than public by a degree. We shouldn't leak types from third part
code into either Public or LP APIs in my opinion. Let's fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message