hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jurriaan Mous (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15978) Netty API leaked into public API
Date Wed, 15 Jun 2016 07:24:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331297#comment-15331297

Jurriaan Mous commented on HBASE-15978:

bq. How about using Java CompletableFuture.

bq. HBase 2.0 is jdk8 only. We voted on it up on dev list.

Ah great. Didn't consider it yet because I thought we had to support jdk7. Now I know I can
use it and the more I read about it the more enthusiastic I get. We can remove things like
PromiseKeeper and other constructions from other patch. I will try to make it the native future
when I have time again in the next few days. No need for future conversion I think. 

> Netty API leaked into public API
> --------------------------------
>                 Key: HBASE-15978
>                 URL: https://issues.apache.org/jira/browse/HBASE-15978
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Nick Dimiduk
>            Assignee: Jurriaan Mous
>            Priority: Blocker
>         Attachments: HBASE-15978-guava.patch, HBASE-15978.patch
> Noticed out public {{[client.Future|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Future.html]}}
interface extends Netty, which means our public API is bound to a specific Netty API and release.
IIRC we were minimizing our public-facing surface area and asserting ownership over the whole
of it so as to control our compatibility. Ie, we've done this with Protobuf as well. Not sure
if this has made it back to other branches.

This message was sent by Atlassian JIRA

View raw message