hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15978) Netty API leaked into public API
Date Tue, 07 Jun 2016 18:53:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319115#comment-15319115
] 

stack commented on HBASE-15978:
-------------------------------

Which issue?

We have a Service that is annotated Private.

{code}
/**
 * Simple Service.
 */
// This is a WIP. We have Services throughout hbase. Either have all implement what is here
or
// just remove this as an experiment that did not work out.
// TODO: Move on to guava Service after we update our guava version; later guava has nicer
// Service implmentation.
// TODO: Move all Services on to this one Interface.
@InterfaceAudience.Private
public interface Service {
{code}

> Netty API leaked into public API
> --------------------------------
>
>                 Key: HBASE-15978
>                 URL: https://issues.apache.org/jira/browse/HBASE-15978
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Nick Dimiduk
>            Priority: Blocker
>
> Noticed out public {{[client.Future|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Future.html]}}
interface extends Netty, which means our public API is bound to a specific Netty API and release.
IIRC we were minimizing our public-facing surface area and asserting ownership over the whole
of it so as to control our compatibility. Ie, we've done this with Protobuf as well. Not sure
if this has made it back to other branches.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message