hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15978) Netty API leaked into public API
Date Tue, 07 Jun 2016 18:38:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319089#comment-15319089
] 

Enis Soztutar commented on HBASE-15978:
---------------------------------------

bq. Related, we have some interfaces inheriting from Guava's Service, like the pluggable replication
ones. This required a private patch to HBase code when I normalized our Guava version cross
stack internally.
Those are not InterfaceAudience.Public, but LimitedPrivate(Coprocessor) FWIW. 

Did not check the APILyzer, but we kind of have a similar thing. See the test that is new
in HBASE-15174. We can extend that to ensure there is no non-HBase in the InterfaceAudience.Public
methods. We might need to whitelist java collections, etc. 





> Netty API leaked into public API
> --------------------------------
>
>                 Key: HBASE-15978
>                 URL: https://issues.apache.org/jira/browse/HBASE-15978
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Nick Dimiduk
>            Priority: Blocker
>
> Noticed out public {{[client.Future|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Future.html]}}
interface extends Netty, which means our public API is bound to a specific Netty API and release.
IIRC we were minimizing our public-facing surface area and asserting ownership over the whole
of it so as to control our compatibility. Ie, we've done this with Protobuf as well. Not sure
if this has made it back to other branches.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message