hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15955) Disable action in CatalogJanitor#setEnabled should wait for active cleanup scan to finish
Date Fri, 03 Jun 2016 20:10:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314714#comment-15314714
] 

Enis Soztutar commented on HBASE-15955:
---------------------------------------

+1. 
bq. enableCatalogJanitor() used to be asynchronous.
That does not seem to be the case anymore. I think having it sync by default is fine. 

> Disable action in CatalogJanitor#setEnabled should wait for active cleanup scan to finish
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-15955
>                 URL: https://issues.apache.org/jira/browse/HBASE-15955
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>         Attachments: HBASE-15955.master-v1.patch
>
>
> When user calls Admin.enableCatalogJanitor(false) to disable the catalog janitor, it
expects that the janitor would stop working once the API returns.  It is not true, the janitor
could have an active scan going on and clean up unused region.  The 'false' state would be
enforced during the next background runs.  
> To avoid confusing, if 'CatalogJanitor.enabled' is true and we want to set to false in
CatalogJanitor#setEnabled, the function should wait for the on-going active scan to complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message