hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15945) Patch for Key Value, Bytes and Cell
Date Wed, 22 Jun 2016 06:37:57 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343799#comment-15343799
] 

Elliott Clark commented on HBASE-15945:
---------------------------------------

bq.We have defined a custom exception class derived from std::exception which we use to throw
exceptions.
Either a exception hierarchy is needed or nothing at all. Right now it's just a carrier for
strings. They are very bad ways to signal things to developers. Types are much much better.
http://blog.tsunanet.net/2012/04/apache-hadoop-abuse-ioexception.html

Lets not repeat that mistake.

bq.There might be some API's or functions which provide some functionality but may not be
called in the patch. Should we remove all such functions ?
Yep. Code is complete when there's nothing more to remove, not when there's nothing more to
add. We don't want to end up with the spralling api that is our java api, so we should only
be adding things that are needed to create the client. Not things that could in the future
be useful.

> Patch for Key Value, Bytes and Cell
> -----------------------------------
>
>                 Key: HBASE-15945
>                 URL: https://issues.apache.org/jira/browse/HBASE-15945
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>         Attachments: HBASE-15945-HBASE-14850.v2.patch, HBASE-15945.HBASE-14850.v1.patch
>
>
> This patch contains an implementation of Key Value, Bytes and Cell modeled on the lines
of Java implementation.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message