hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15945) Patch for Key Value, Bytes and Cell
Date Wed, 22 Jun 2016 03:19:57 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343641#comment-15343641
] 

Elliott Clark commented on HBASE-15945:
---------------------------------------

This is the same Java in cpp stuff that's been posted a couple of times.
If we want to have something that can share the same buffers and has offset and all then use
IOBuf. If you just want a straight array of bytes then use string ( the same thing that protobuf
uses)


Exceptions should be meaningful or they should be runtime_error.

Code that's not used shouldn't be checked in. Code that's just there to add unused maybe needed
functionality is just going to be bloat.

> Patch for Key Value, Bytes and Cell
> -----------------------------------
>
>                 Key: HBASE-15945
>                 URL: https://issues.apache.org/jira/browse/HBASE-15945
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>         Attachments: HBASE-15945-HBASE-14850.v2.patch, HBASE-15945.HBASE-14850.v1.patch
>
>
> This patch contains an implementation of Key Value, Bytes and Cell modeled on the lines
of Java implementation.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message