hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it
Date Thu, 09 Jun 2016 19:38:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323180#comment-15323180

Gary Helmling commented on HBASE-15921:

The replacement of HTable by TableImpl comes later?
It is already replaced at getTable in Connection in this patch. I want to make sure the performance
is ok and then I find a solution for the remaining HTable refs.

So this patch completely removes access to HTable from ConnectionImplementation?

I haven't had time to look through the patch in detail, yet, but I don't think it's appropriate
to remove the ability to use the current HTable implementation in this patch.  TableImpl needs
to wait or be exposed in a different way than changing ConnectionImplementation.getTable().
 AsyncTableImpl and HTable need to exist side by side for a while, giving a chance for issues
to be worked out.  Performance is only one consideration.  For all of their problems, the
current HTable and RpcClient code paths have had a lot of work invested in squashing bugs
and bad behavior.  AsyncTableImpl needs to demonstrate a similar level of behavior before
it becomes the only implementation.

> Add first AsyncTable impl and create TableImpl based on it
> ----------------------------------------------------------
>                 Key: HBASE-15921
>                 URL: https://issues.apache.org/jira/browse/HBASE-15921
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-15921.patch, HBASE-15921.v1.patch
> First we create an AsyncTable interface with implementation without the Scan functionality.
Those will land in a separate patch since they need a refactor of existing scans.
> Also added is a new TableImpl to replace HTable. It uses the AsyncTableImpl internally
and should be a bit faster because it does jump through less hoops to do ProtoBuf transportation.
This way we can run all existing tests on the AsyncTableImpl to guarantee its quality.

This message was sent by Atlassian JIRA

View raw message