hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15893) Get object
Date Wed, 01 Jun 2016 20:05:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311012#comment-15311012
] 

Enis Soztutar commented on HBASE-15893:
---------------------------------------

bq. That's how bytes are passed back. If we want to have something like slice that's what
IOBuf's are.
That is fine if all you do is get with a key for a single cell. We still need a way to iterate
over (rowKey,column+ts -> value) mappings within a given row, as a result of Get, or iterate
over the results of Scan. 
Even levelDB's scan iterator is Slice based, however, unlike levelDB where there is only key,
we have rowKey+cf+column+ts to represent somehow. 
https://github.com/google/leveldb/blob/master/include/leveldb/iterator.h#L65

bq. The only difference between cell and key value is what accessors are there. Cell was a
hack to get around removing some that made promises around data layout. 
KV was a bad idea in the first place. It ties the underlying representation of the in-memory
data model to a very specific representation. We should not make the same mistake and make
the implementation know the returned representation format in the new client. 

bq. We have no such inconveniences around having already promised a static data layout, hence
the cell/kv difference isn't needed. 
We should not "promise" any specific in-memory representation hence we still need a way to
abstract an interface so that you can iterate over a single Get results, and still can inspect
the column names, timestamps, etc. It does not necessarily be cell versus KV, but we need
the abstraction in place. 


> Get object
> ----------
>
>                 Key: HBASE-15893
>                 URL: https://issues.apache.org/jira/browse/HBASE-15893
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>         Attachments: HBASE-15893.HBASE-14850.v1.patch
>
>
> Patch for creating Get objects.  Get objects can be passed to the Table implementation
to fetch results for a given row. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message