hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15889) String case conversions are locale-sensitive, used without locale
Date Wed, 08 Jun 2016 12:51:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320482#comment-15320482
] 

Hudson commented on HBASE-15889:
--------------------------------

FAILURE: Integrated in HBase-0.98-matrix #353 (See [https://builds.apache.org/job/HBase-0.98-matrix/353/])
HBASE-15889. String case conversions are locale-sensitive, used without (apurtell: rev e26800c027fc010fd72c4bb2b78997ea30466606)
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestIPv6NIOServerSocketChannel.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerCommandLine.java
* hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceFactoryImpl.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SubstringComparator.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/DataBlockEncodingTool.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScanBase.java
* hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/filter/GzipFilter.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/CreateSnapshot.java
* hbase-annotations/src/main/java/org/apache/hadoop/hbase/classification/tools/StabilityOptions.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/StripeCompactionsPerformanceEvaluation.java
* hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/test/MetricsAssertHelperImpl.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatTestBase.java
* hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceFactoryImpl.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/KeyStoreKeyProvider.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
* hbase-hadoop1-compat/src/test/java/org/apache/hadoop/hbase/test/MetricsAssertHelperImpl.java


> String case conversions are locale-sensitive, used without locale
> -----------------------------------------------------------------
>
>                 Key: HBASE-15889
>                 URL: https://issues.apache.org/jira/browse/HBASE-15889
>             Project: HBase
>          Issue Type: Bug
>          Components: localization
>    Affects Versions: 1.2.0
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>            Priority: Minor
>             Fix For: 2.0.0, 1.4.0, 0.98.20
>
>         Attachments: HBASE-15889-branch-1.v2.patch, HBASE-15889-v1.patch, HBASE-15891-v2.patch
>
>
> Static code analysis is flagging cases of String.toLowerCase and String.toUpperCase being
used without Locale. From the API reference:
> {quote}
> Note: This method is locale sensitive, and may produce unexpected results if used for
strings that are intended to be interpreted locale independently. Examples are programming
language identifiers, protocol keys, and HTML tags. For instance, "TITLE".toLowerCase() in
a Turkish locale returns "t\u0131tle", where '\u0131' is the LATIN SMALL LETTER DOTLESS I
character. To obtain correct results for locale insensitive strings, use toLowerCase(Locale.ROOT).
> {quote}
> Many uses of these functions do appear to be looking up classes, etc. and not dealing
with stored data, so I'd think there aren't significant compatibility problems here and specifying
the locale is indeed the safer way to go.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message