hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15845) Shell Cleanup : move formatter to commands.rb; move one of the two hbase.rb to hbase_constants.rb
Date Fri, 03 Jun 2016 23:38:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315105#comment-15315105
] 

Appy commented on HBASE-15845:
------------------------------

Pushed to branch-1 without the hbase.rb file move. There are more shell changes coming after
this, and I want to prevent master diverging too much from earlier branches.

> Shell Cleanup : move formatter to commands.rb; move one of the two hbase.rb to hbase_constants.rb
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15845
>                 URL: https://issues.apache.org/jira/browse/HBASE-15845
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>            Priority: Minor
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-15845-master-v1.patch, HBASE-15845-master-v2.patch
>
>
> -  Renaming hbase.rb to hbase_constants.rb because there are two hbase.rb files right
now which is confusing. The constants are meant for shell, users shouldn't be using it directly.
Anyways, this file is moved only in 2.0. In earlier branches, the files isn't renamed.
> - Remove omnipresence of formatter object since it is kind of a use-and-throw class.
Commands should create
>       an instance, use it to format the output and discard it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message