hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15698) Increment TimeRange not serialized to server
Date Sun, 05 Jun 2016 03:53:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315715#comment-15315715
] 

Ted Yu commented on HBASE-15698:
--------------------------------

The reason for test failure of patch v3 was that:
{code}
+    TimeRange range2 = new TimeRange(1, EnvironmentEdgeManager.currentTime()+2);
+    List<Row> actions =
+        Arrays.asList(new Row[] { new Increment(ROW_A).addColumn(TEST_FAMILY, qualifierCol1,
2L)
+            .setTimeRange(range2.getMin(), range2.getMax()),
+            new Increment(ROW_A).addColumn(TEST_FAMILY, qualifierCol1, 2L)
+            .setTimeRange(range2.getMin(), range2.getMax()) });
{code}
By the time the first Increment is done, range2.getMax() is exceeded (I wasn't careful when
choosing the 2).
The second Increment wouldn't find the value resulting from the first Increment.

Patch v5 doesn't have this shortcoming.

> Increment TimeRange not serialized to server
> --------------------------------------------
>
>                 Key: HBASE-15698
>                 URL: https://issues.apache.org/jira/browse/HBASE-15698
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: James Taylor
>            Assignee: Ted Yu
>            Priority: Blocker
>              Labels: phoenix
>             Fix For: 1.3.0, 1.4.0, 1.2.2, 0.98.20, 1.1.6
>
>         Attachments: 15698-suggest.txt, 15698.v1.txt, 15698.v2.txt, 15698.v3.txt, 15698.v4.txt,
15698.v4.txt, 15698.v5.txt, HBASE-15698.1.patch
>
>
> Before HBase-1.2, the Increment TimeRange set on the client was serialized over to the
server. As of HBase 1.2, this appears to no longer be true, as my preIncrement coprocessor
always gets HConstants.LATEST_TIMESTAMP as the value of increment.getTimeRange().getMax()
regardless of what the client has specified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message