Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 28 May 2016 15:16:12 +0000 (UTC)
From: "Sean Mackrory (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12972750.1464190396000.325045.1464448572829@Atlassian.JIRA>
In-Reply-To: <JIRA.12972750.1464190396000@Atlassian.JIRA>
References: <JIRA.12972750.1464190396000@Atlassian.JIRA> <JIRA.12972750.1464190396110@arcas>
Subject: [jira] [Commented] (HBASE-15889) String case conversions are
 locale-sensitive, used without locale
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 28 May 2016 15:16:14 -0000


    [ https://issues.apache.org/jira/browse/HBASE-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305438#comment-15305438 ] 

Sean Mackrory commented on HBASE-15889:
---------------------------------------

2 findbugs warnings aren't related to my patch. Happy to fix them in another, though, if they're not already being looked at. Weirdly I don't see such results in other recent patches?

> String case conversions are locale-sensitive, used without locale
> -----------------------------------------------------------------
>
>                 Key: HBASE-15889
>                 URL: https://issues.apache.org/jira/browse/HBASE-15889
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.0
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>            Priority: Minor
>         Attachments: HBASE-15889-v1.patch, HBASE-15891-v2.patch
>
>
> Static code analysis is flagging cases of String.toLowerCase and String.toUpperCase being used without Locale. From the API reference:
> {quote}
> Note: This method is locale sensitive, and may produce unexpected results if used for strings that are intended to be interpreted locale independently. Examples are programming language identifiers, protocol keys, and HTML tags. For instance, "TITLE".toLowerCase() in a Turkish locale returns "t\u0131tle", where '\u0131' is the LATIN SMALL LETTER DOTLESS I character. To obtain correct results for locale insensitive strings, use toLowerCase(Locale.ROOT).
> {quote}
> Many uses of these functions do appear to be looking up classes, etc. and not dealing with stored data, so I'd think there aren't significant compatibility problems here and specifying the locale is indeed the safer way to go.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)