Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 94EB5200B32 for ; Wed, 25 May 2016 04:53:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9359E160A37; Wed, 25 May 2016 02:53:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8E9F160A35 for ; Wed, 25 May 2016 04:53:13 +0200 (CEST) Received: (qmail 98549 invoked by uid 500); 25 May 2016 02:53:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 98514 invoked by uid 99); 25 May 2016 02:53:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 May 2016 02:53:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D81C82C1F61 for ; Wed, 25 May 2016 02:53:12 +0000 (UTC) Date: Wed, 25 May 2016 02:53:12 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15885) Compute StoreFile HDFS Blocks Distribution when needed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 25 May 2016 02:53:14 -0000 [ https://issues.apache.org/jira/browse/HBASE-15885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299363#comment-15299363 ] Ted Yu commented on HBASE-15885: -------------------------------- Have you measured the savings in time by reducing the hdfs block distribution calculation ? Thanks > Compute StoreFile HDFS Blocks Distribution when needed > ------------------------------------------------------ > > Key: HBASE-15885 > URL: https://issues.apache.org/jira/browse/HBASE-15885 > Project: HBase > Issue Type: Improvement > Components: HFile > Affects Versions: 2.0.0 > Reporter: Guanghao Zhang > Attachments: HBASE-15885.patch > > > Now when open a StoreFileReader, it always need to compute HDFS blocks distribution. But when balance a region, it will increase the region not serving time. Because it need first close region on rs A, then open it on rs B. When close region, it first preFlush, then flush the new update to a new store file. The new store file will first be flushed to tmp directory, then move it to column family directory. These need open StoreFileReader twice which means it need compute HDFS blocks distribution twice. When open region on rs B, it need open StoreFileReader and compute HDFS blocks distribution too. So when balance a region, it need compute HDFS blocks distribution three times for per new store file. This will increase the region not serving time and we don't need compute HDFS blocks distribution when close a region. > The related three methods in HStore. > 1. validateStoreFile(...) > 2. commitFile(...) > 3. openStoreFiles(...) -- This message was sent by Atlassian JIRA (v6.3.4#6332)