Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 40EE62009F3 for ; Fri, 20 May 2016 21:00:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3FD18160A24; Fri, 20 May 2016 19:00:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7104F160A25 for ; Fri, 20 May 2016 21:00:15 +0200 (CEST) Received: (qmail 73669 invoked by uid 500); 20 May 2016 19:00:14 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 73576 invoked by uid 99); 20 May 2016 19:00:14 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 May 2016 19:00:14 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 65D1E2C1F6C for ; Fri, 20 May 2016 19:00:14 +0000 (UTC) Date: Fri, 20 May 2016 19:00:14 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15856) Cached Connection instances can wind up with addresses never resolved MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 20 May 2016 19:00:16 -0000 [ https://issues.apache.org/jira/browse/HBASE-15856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293976#comment-15293976 ] Hudson commented on HBASE-15856: -------------------------------- SUCCESS: Integrated in HBase-1.3-IT #670 (See [https://builds.apache.org/job/HBase-1.3-IT/670/]) HBASE-15856 Don't cache unresolved addresses for connections (garyh: rev efdc0e10096413460fff9c23929da0f980ddf941) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestConnectionImplementation.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java > Cached Connection instances can wind up with addresses never resolved > --------------------------------------------------------------------- > > Key: HBASE-15856 > URL: https://issues.apache.org/jira/browse/HBASE-15856 > Project: HBase > Issue Type: Bug > Components: Client > Reporter: Gary Helmling > Assignee: Gary Helmling > Priority: Critical > Fix For: 2.0.0, 1.3.0, 1.2.2 > > Attachments: HBASE-15856.001.patch, HBASE-15856.002.patch, HBASE-15856.003.patch > > > During periods where DNS is not working properly, we can wind up caching connections to master or regionservers where the initial hostname resolution and the resolution is never re-attempted. This means that clients will forever get UnknownHostException for any calls. > When constructing a BlockingRpcChannelImplementation, we instantiate the InetSocketAddress to use for the connection. This instance is then used in the rpc client connection, where we check isUnresolved() and throw an UnknownHostException if that returns true. However, at this point the rpc channel is already cached in the HConnectionImplementation map of stubs. So at this point it will never be resolved. > Setting the config for hbase.resolve.hostnames.on.failure masks this issue, since the stub key used is modified to contain the address. However, even in that case, if DNS fails, an rpc channel instance with unresolved ISA will still be cached in the stubs under the hostname only key. -- This message was sent by Atlassian JIRA (v6.3.4#6332)