Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E8AF1200AEF for ; Sat, 14 May 2016 05:21:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E78AF16099F; Sat, 14 May 2016 03:21:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 442C4160A12 for ; Sat, 14 May 2016 05:21:14 +0200 (CEST) Received: (qmail 61689 invoked by uid 500); 14 May 2016 03:21:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 61422 invoked by uid 99); 14 May 2016 03:21:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 May 2016 03:21:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 055922C1F61 for ; Sat, 14 May 2016 03:21:13 +0000 (UTC) Date: Sat, 14 May 2016 03:21:13 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15827) Backport HBASE-15125 'HBaseFsck's adoptHdfsOrphan function creates region with wrong end key boundary' to 1.1 and 1.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 14 May 2016 03:21:15 -0000 [ https://issues.apache.org/jira/browse/HBASE-15827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283393#comment-15283393 ] Ted Yu commented on HBASE-15827: -------------------------------- Got some test failures on the backport to branch-1.1 : {code} testRegionHole(org.apache.hadoop.hbase.util.TestHBaseFsck) Time elapsed: 5.866 sec <<< FAILURE! java.lang.AssertionError: expected:<[HOLE_IN_REGION_CHAIN]> but was:<[HOLE_IN_REGION_CHAIN, EXPIRED_TABLE_LOCK]> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.assertErrors(HbckTestingUtil.java:99) at org.apache.hadoop.hbase.util.TestHBaseFsck.testRegionHole(TestHBaseFsck.java:1189) testNotInMetaOrDeployedHole(org.apache.hadoop.hbase.util.TestHBaseFsck) Time elapsed: 5.877 sec <<< FAILURE! java.lang.AssertionError: expected:<[NOT_IN_META_OR_DEPLOYED, HOLE_IN_REGION_CHAIN]> but was:<[NOT_IN_META_OR_DEPLOYED, HOLE_IN_REGION_CHAIN, EXPIRED_TABLE_LOCK]> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.assertErrors(HbckTestingUtil.java:99) at org.apache.hadoop.hbase.util.TestHBaseFsck.testNotInMetaOrDeployedHole(TestHBaseFsck.java:1307) testMissingFirstRegion(org.apache.hadoop.hbase.util.TestHBaseFsck) Time elapsed: 5.869 sec <<< FAILURE! java.lang.AssertionError: expected:<[FIRST_REGION_STARTKEY_NOT_EMPTY]> but was:<[FIRST_REGION_STARTKEY_NOT_EMPTY, EXPIRED_TABLE_LOCK]> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.assertErrors(HbckTestingUtil.java:99) at org.apache.hadoop.hbase.util.TestHBaseFsck.testMissingFirstRegion(TestHBaseFsck.java:1867) {code} Will investigate later. > Backport HBASE-15125 'HBaseFsck's adoptHdfsOrphan function creates region with wrong end key boundary' to 1.1 and 1.2 > --------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-15827 > URL: https://issues.apache.org/jira/browse/HBASE-15827 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Fix For: 1.2.2 > > Attachments: 15827-branch-1.2.patch > > > There is a bug in HBaseFsck's adoptHdfsOrphan function.At the last of this function will create a region,which want to cover all the orphan regions.But the end key of this new region was set incorrectly.Correct region's boundary should be [startKey,endKey),but this function create a region with boundary of [startKey,endKey],this bug will leads to scan operation omit some data. > I think we should create the region like bellow, > {code} > // create new region on hdfs. move data into place. > HRegionInfo hri = new HRegionInfo(template.getTableName(), orphanRegionRange.getFirst(), > Bytes.add(orphanRegionRange.getSecond(), new byte[1])); > {code} > This is to backport to branch-1.1 and branch-1.2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)