Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C79AD200AE4 for ; Tue, 10 May 2016 11:06:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C605C1607AA; Tue, 10 May 2016 09:06:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1FB0E160A11 for ; Tue, 10 May 2016 11:06:13 +0200 (CEST) Received: (qmail 36358 invoked by uid 500); 10 May 2016 09:06:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 36265 invoked by uid 99); 10 May 2016 09:06:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 May 2016 09:06:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F26A52C1F68 for ; Tue, 10 May 2016 09:06:12 +0000 (UTC) Date: Tue, 10 May 2016 09:06:12 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15799) Two Shell 'close_region' Example Syntaxes Don't Work MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 10 May 2016 09:06:14 -0000 [ https://issues.apache.org/jira/browse/HBASE-15799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277832#comment-15277832 ] Hudson commented on HBASE-15799: -------------------------------- FAILURE: Integrated in HBase-Trunk_matrix #911 (See [https://builds.apache.org/job/HBase-Trunk_matrix/911/]) HBASE-15799 Two Shell 'close_region' Example Syntaxes Don't Work (Matt (tedyu: rev 3b74b6f329ad6ebc0d2d2548a7e1290297674529) * hbase-shell/src/main/ruby/hbase/admin.rb * hbase-shell/src/test/ruby/hbase/admin_test.rb * hbase-shell/src/main/ruby/shell/commands/close_region.rb > Two Shell 'close_region' Example Syntaxes Don't Work > ---------------------------------------------------- > > Key: HBASE-15799 > URL: https://issues.apache.org/jira/browse/HBASE-15799 > Project: HBase > Issue Type: Bug > Components: shell > Affects Versions: 2.0.0 > Reporter: Matt Warhaftig > Assignee: Matt Warhaftig > Priority: Minor > Attachments: hbase-15799-v1.patch > > > The close_region shell command's help message lists the following usage syntaxes: > {noformat} > hbase> close_region 'REGIONNAME' > hbase> close_region 'REGIONNAME', 'SERVER_NAME' > hbase> close_region 'ENCODED_REGIONNAME' > hbase> close_region 'ENCODED_REGIONNAME', 'SERVER_NAME' > {noformat} > admin.rb's current code (with close_region method being the entry point) is: > {code} > def close_region(region_name, server) > if (server == nil || !closeEncodedRegion?(region_name, server)) > @admin.closeRegion(region_name, server) > end > end > def closeEncodedRegion?(region_name, server) > @admin.closeRegionWithEncodedRegionName(region_name, server) > end > {code} > The {{close_region 'ENCODED_REGIONNAME'}} syntax currently will not work because when server = nil the {{closeEncodedRegion}} method call is skipped. > The {{close_region 'REGIONNAME', 'SERVER_NAME'}} syntax currently will not work because {{@admin.closeRegionWithEncodedRegionName}} throws an NotServingRegionException (for the non-encoded region_name) that is uncaught in and prevents execution from returning to {{close_region}} and the correct call of {{HBaseAdmin.closeRegion}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)