Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AC22A200AF2 for ; Wed, 4 May 2016 19:53:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AB07D1609FF; Wed, 4 May 2016 17:53:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 06F191609FC for ; Wed, 4 May 2016 19:53:14 +0200 (CEST) Received: (qmail 75949 invoked by uid 500); 4 May 2016 17:53:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 75546 invoked by uid 99); 4 May 2016 17:53:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 May 2016 17:53:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 899BD2C1F6C for ; Wed, 4 May 2016 17:53:13 +0000 (UTC) Date: Wed, 4 May 2016 17:53:13 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15759) RegionObserver.preStoreScannerOpen() doesn't have acces to current readpoint MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 04 May 2016 17:53:15 -0000 [ https://issues.apache.org/jira/browse/HBASE-15759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-15759: --------------------------- Attachment: 15759.v3.patch Patch v3 addresses failed tests. > RegionObserver.preStoreScannerOpen() doesn't have acces to current readpoint > ---------------------------------------------------------------------------- > > Key: HBASE-15759 > URL: https://issues.apache.org/jira/browse/HBASE-15759 > Project: HBase > Issue Type: Improvement > Components: Coprocessors > Reporter: Marek Srank > Assignee: Ted Yu > Priority: Minor > Labels: coprocessors > Attachments: 15759.v1.patch, 15759.v2.patch, 15759.v3.patch > > > RegionObserver.preStoreScannerOpen() doesn't have acces to current readpoint. This is crucial e.g. when creating a new StoreScanner. > Although it is possible to obtain the readpoint via following workaround: > ((HStore)store).getHRegion().getReadpoint(IsolationLevel.READ_COMMITTED) > ...it presumes some knowledge of HBase internals and is not a clear option for user. > The problem was introduced in HBASE-9754, where readpoint was introduced as an argument to StoreScanner constructor, but wasn't passed to the preStoreScannerOpen() hook in HStore.getScanner(). > In our case it led to bug, when we were incorrectly using smallestReadpoint() instead, which made coprocessor missing data in some cases [1]. > __________ > [1] http://mail-archives.apache.org/mod_mbox/hbase-dev/201604.mbox/%3CCAOUjMkwptCGacQ0d-4yOinDVBT%2Bbi2NOZee0fSbq%2Bk1R6V4-aw%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)