Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AFB5C200AF7 for ; Tue, 10 May 2016 01:43:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AE4B3160A0F; Mon, 9 May 2016 23:43:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 097E41609A8 for ; Tue, 10 May 2016 01:43:13 +0200 (CEST) Received: (qmail 36559 invoked by uid 500); 9 May 2016 23:43:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 36538 invoked by uid 99); 9 May 2016 23:43:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 May 2016 23:43:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DAF9F2C1F5D for ; Mon, 9 May 2016 23:43:12 +0000 (UTC) Date: Mon, 9 May 2016 23:43:12 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 09 May 2016 23:43:14 -0000 [ https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277344#comment-15277344 ] Hudson commented on HBASE-15740: -------------------------------- SUCCESS: Integrated in HBase-1.4 #144 (See [https://builds.apache.org/job/HBase-1.4/144/]) HBASE-15740 Replication source.shippedKBs metric is undercounting (enis: rev d07d31611395ae4e0befc04a0b8cc67adcacacb9) * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java > Replication source.shippedKBs metric is undercounting because it is in KB > ------------------------------------------------------------------------- > > Key: HBASE-15740 > URL: https://issues.apache.org/jira/browse/HBASE-15740 > Project: HBase > Issue Type: Sub-task > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: hbase-15740_v1.patch, hbase-15740_v2.patch > > > In a cluster where there is replication going on, I've noticed that this is always 0: > {code} > "source.shippedKBs" : 0, > {code} > Looking at the source reveals why: > {code} > metrics.shipBatch(currentNbOperations, currentSize / 1024, currentNbHFiles); > {code} > It is always undercounting because we discard remaining bytes after KB boundary. This is specially a problem when we are always shipping small batches <1KB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)