Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AA0872009A0 for ; Sat, 7 May 2016 07:25:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A8B09160A0E; Sat, 7 May 2016 05:25:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F016B1609AF for ; Sat, 7 May 2016 07:25:13 +0200 (CEST) Received: (qmail 50260 invoked by uid 500); 7 May 2016 05:25:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 50248 invoked by uid 99); 7 May 2016 05:25:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 May 2016 05:25:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D17B92C1F61 for ; Sat, 7 May 2016 05:25:12 +0000 (UTC) Date: Sat, 7 May 2016 05:25:12 +0000 (UTC) From: "Guanghao Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15615) Wrong sleep time when RegionServerCallable need retry MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 07 May 2016 05:25:14 -0000 [ https://issues.apache.org/jira/browse/HBASE-15615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275096#comment-15275096 ] Guanghao Zhang commented on HBASE-15615: ---------------------------------------- When working with this issue, I found that hbase.client.retries.number has different meanings in branch-1 and master. In branch-1, the max attempts number equals with hbase.client.retries.number. But in master, the max attempts number equals with hbase.client.retries.number + 1. I am not sure which one is right. The comment of hbase.client.retries.number is: {code} /** * Parameter name for maximum retries, used as maximum for all retryable * operations such as fetching of the root region from root region server, * getting a cell's value, starting a row update, etc. */ public static final String HBASE_CLIENT_RETRIES_NUMBER = "hbase.client.retries.number"; {code} > Wrong sleep time when RegionServerCallable need retry > ----------------------------------------------------- > > Key: HBASE-15615 > URL: https://issues.apache.org/jira/browse/HBASE-15615 > Project: HBase > Issue Type: Bug > Components: Client > Affects Versions: 1.0.0, 2.0.0, 1.1.0, 1.2.0, 1.3.0 > Reporter: Guanghao Zhang > Assignee: Guanghao Zhang > Fix For: 1.3.0 > > Attachments: HBASE-15615-branch-1.0-v2.patch, HBASE-15615-branch-1.1-v2.patch, HBASE-15615-branch-1.patch, HBASE-15615-v1.patch, HBASE-15615-v1.patch, HBASE-15615-v2.patch, HBASE-15615.patch > > > In RpcRetryingCallerImpl, it get pause time by expectedSleep = callable.sleep(pause, tries + 1); And in RegionServerCallable, it get pasue time by sleep = ConnectionUtils.getPauseTime(pause, tries + 1). So tries will be bumped up twice. And the pasue time is 3 * hbase.client.pause when tries is 0. > RETRY_BACKOFF = {1, 2, 3, 5, 10, 20, 40, 100, 100, 100, 100, 200, 200} -- This message was sent by Atlassian JIRA (v6.3.4#6332)