Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 832C92009A0 for ; Tue, 3 May 2016 14:31:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 823AF1609F3; Tue, 3 May 2016 14:31:14 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D56501609F4 for ; Tue, 3 May 2016 14:31:13 +0200 (CEST) Received: (qmail 134 invoked by uid 500); 3 May 2016 12:31:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 113 invoked by uid 99); 3 May 2016 12:31:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 May 2016 12:31:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CBDD82C14F9 for ; Tue, 3 May 2016 12:31:12 +0000 (UTC) Date: Tue, 3 May 2016 12:31:12 +0000 (UTC) From: "Matt Warhaftig (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15563) 'counter' may overflow in BoundedGroupingStrategy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 03 May 2016 12:31:14 -0000 [ https://issues.apache.org/jira/browse/HBASE-15563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268622#comment-15268622 ] Matt Warhaftig commented on HBASE-15563: ---------------------------------------- Below are results for time to get groupNames array element for Integer.Max_Value*2 records across multiple thread counts. Counter reset code was closely adapted from AtomicInteger.getAndIncrement(). || Threads || AtomicLong Run Time || Counter Reset Run Time || % Difference || | 1 | 65s | 66s | + 1.5% | | 2 | 186s | 219s | +16% | | 4 | 287s | 317s | +10% | The Counter Reset method is a little slower but still I will put it into a quick patch tonight. > 'counter' may overflow in BoundedGroupingStrategy > ------------------------------------------------- > > Key: HBASE-15563 > URL: https://issues.apache.org/jira/browse/HBASE-15563 > Project: HBase > Issue Type: Bug > Components: wal > Reporter: Duo Zhang > Assignee: Matt Warhaftig > Priority: Minor > Labels: beginner > Attachments: hbase-15563-v1.patch > > > {code} > groupName = groupNames[counter.getAndIncrement() % groupNames.length]; > {code} > Theoretically, counter can overflow and becomes negative then causes an ArrayIndexOutOfBoundsException. > But in practice, we need 2 billions different identifiers to make this happen, and before the overflow we will run into OOM because of a huge groupNameCache... > So not sure if it is worth to fix -- This message was sent by Atlassian JIRA (v6.3.4#6332)