Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8C16B200AE4 for ; Thu, 26 May 2016 06:29:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8B116160A34; Thu, 26 May 2016 04:29:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0360A160A29 for ; Thu, 26 May 2016 06:29:14 +0200 (CEST) Received: (qmail 43138 invoked by uid 500); 26 May 2016 04:29:14 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 43122 invoked by uid 99); 26 May 2016 04:29:14 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 May 2016 04:29:14 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 04B6E2C1F62 for ; Thu, 26 May 2016 04:29:13 +0000 (UTC) Date: Thu, 26 May 2016 04:29:13 +0000 (UTC) From: "Matteo Bertozzi (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14635) Fix flaky test TestSnapshotCloneIndependence MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 26 May 2016 04:29:15 -0000 [ https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301505#comment-15301505 ] Matteo Bertozzi commented on HBASE-14635: ----------------------------------------- +1 > Fix flaky test TestSnapshotCloneIndependence > -------------------------------------------- > > Key: HBASE-14635 > URL: https://issues.apache.org/jira/browse/HBASE-14635 > Project: HBase > Issue Type: Task > Components: test > Reporter: stack > Assignee: Appy > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-14635-master-v2.patch, HBASE-14635-master-v3.patch, HBASE-14635-master-v4.patch, HBASE-14635-master.patch > > > So the main bug fix here is that if online is set to false, {{createSnapshotAndValidate}} disables the original table. So instead of current code doing > {noformat} > if (!online) { > tryDisable(admin, localTableName); > } > {noformat} > we should be doing > {noformat} > if (!online) { > admin.enableTable(originalTableName); > UTIL.waitTableAvailable(originalTableName); > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)