hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dima Spivak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15917) Flaky tests dashboard
Date Tue, 31 May 2016 17:07:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15308129#comment-15308129

Dima Spivak commented on HBASE-15917:

Some mostly nit-y Python comments:
* Instead of documenting functions with leading {{ \# }}s, use triple double-quotes for docstrings
(see PEP 257).
* {{get_bad_tests}} might work better returning a tuple than a list since you probably want
this immutable.
* Replace {{print}}s with logging objects when applicable (e.g. for script status updates).
* Move the HTML template to its own file instead of putting it inline. We should probably
do the same with the stylesheet, too.

Really cool idea here, [~appy]. Good work.

> Flaky tests dashboard
> ---------------------
>                 Key: HBASE-15917
>                 URL: https://issues.apache.org/jira/browse/HBASE-15917
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-15917.master.001.addendum.patch, HBASE-15917.master.001.addendum2.patch,
> report-flakies.py now outputs a file dashboard.html.
> Then the dashboard will always be accessible from https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html
> *(See [this external link|http://hbase.x10host.com/flaky-tests/] for pretty version.)*
> Currently it shows:
> Failing tests
> flakyness %
> count of times a test failed, timed out or hanged
> Links to jenkins' runs grouped by whether the test succeeded, failed, timed out and was
hanging in that run.
> Also, once we have set timeouts to tests, they'll not be "hanging" anymore since they'll
fail with timeout. Handle this minor difference in findHangingTests.py and show the corresponding
stats in dashboard.

This message was sent by Atlassian JIRA

View raw message