hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15875) Remove HTable references and HTableInterface
Date Sun, 22 May 2016 16:50:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295630#comment-15295630

stack commented on HBASE-15875:

Would it help if we did HBASE-15610 first [~jurmous]? (Looking at the patch, it doesn't look
necessary... can be done afterward).

I opened HBASE-15876 to manage the removal of doBulkLoad. It is problematic removing this
method from a public, stable class (though it a damaged method with its reference to a deprecated

Removal of autoflush needs flagging in release notes here as incompatible (allowed) change.

This patch is great.

> Remove HTable references and HTableInterface
> --------------------------------------------
>                 Key: HBASE-15875
>                 URL: https://issues.apache.org/jira/browse/HBASE-15875
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-15875.patch
> I want to add a new AsyncTable implementation and to do that with great quality I want
to run all the tests with a sync Table implementation which uses the AsyncTable within. To
do this the HbaseTestingUtility has to return Table instead of HTable.
> I saw this as the ideal opportunity to remove all deprecated HTableInterface methods
in 2.0 branch and thus the interface itself. This means all auto flush settings are removed.
> Some discussion points:
> * I had to remove doBulkLoad(Path hfofDir, final HTable table) from LoadIncrementalHFiles
because of the hard HTable usage and replaced usages to the other doBulkLoad(Path hfofDir,
final Admin admin, Table table, RegionLocator regionLocator) method.
> * HBaseTestingUtility now returns Table instead of HTable
> * I removed all the methods from HConnection that were also in Connection + I removed
the getTable methods which should not be used anymore. (HConnection is deprecated so could
be removed itself)

This message was sent by Atlassian JIRA

View raw message