hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-15856) Cached Connection instances can wind up with addresses never resolved
Date Thu, 19 May 2016 20:09:13 GMT

     [ https://issues.apache.org/jira/browse/HBASE-15856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Gary Helmling updated HBASE-15856:
    Attachment: HBASE-15856.001.patch

The attached patch forces a throw of UnknownHostException if we were unable to resolve the
server hostname on rpc channel creation.  This should force an early out and retries where
appropriate, and will prevent unresolved ISA's from being cached.

This also adds a test verifying that bad hostnames throw an exception.

> Cached Connection instances can wind up with addresses never resolved
> ---------------------------------------------------------------------
>                 Key: HBASE-15856
>                 URL: https://issues.apache.org/jira/browse/HBASE-15856
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>            Priority: Critical
>             Fix For: 2.0.0, 1.3.0, 1.2.2
>         Attachments: HBASE-15856.001.patch
> During periods where DNS is not working properly, we can wind up caching connections
to master or regionservers where the initial hostname resolution and the resolution is never
re-attempted.  This means that clients will forever get UnknownHostException for any calls.
> When constructing a BlockingRpcChannelImplementation, we instantiate the InetSocketAddress
to use for the connection.  This instance is then used in the rpc client connection, where
we check isUnresolved() and throw an UnknownHostException if that returns true.  However,
at this point the rpc channel is already cached in the HConnectionImplementation map of stubs.
 So at this point it will never be resolved.
> Setting the config for hbase.resolve.hostnames.on.failure masks this issue, since the
stub key used is modified to contain the address.  However, even in that case, if DNS fails,
an rpc channel instance with unresolved ISA will still be cached in the stubs under the hostname
only key.

This message was sent by Atlassian JIRA

View raw message