hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15843) Replace RegionState.getRegionInTransition() Map with a Set
Date Thu, 19 May 2016 00:13:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290134#comment-15290134
] 

Hudson commented on HBASE-15843:
--------------------------------

FAILURE: Integrated in HBase-Trunk_matrix #930 (See [https://builds.apache.org/job/HBase-Trunk_matrix/930/])
HBASE-15843 Replace RegionState.getRegionInTransition() Map with a Set (matteo.bertozzi: rev
5ac54e6abb4e14f3d2fb2e013a7688d7043a60d3)
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterStatusServlet.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java
* hbase-shell/src/main/ruby/hbase/admin.rb
* hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
* hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/AssignmentManagerStatusTmpl.jamon
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckOneRS.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java


> Replace RegionState.getRegionInTransition() Map with a Set
> ----------------------------------------------------------
>
>                 Key: HBASE-15843
>                 URL: https://issues.apache.org/jira/browse/HBASE-15843
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, Region Assignment
>    Affects Versions: 2.0.0, 1.3.0, 1.2.1
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-15843-v0.patch, HBASE-15843-v1.patch, HBASE-15843-v2.patch,
HBASE-15843-v2_branch-1.patch
>
>
> RegionState.getRegionInTransition() is always used as a Set.
> replace the Map with a Set, avoid some allocation and extra code.
> also ClusterStatus.RegionInTransition has duplicated information.
> The spec field contains the regionName (not encoded). 
> but we have the same info as part of the region_state with the HRegionInfo serialized.
> unfortunately I don't think we can get rid of 'spec' that being a required field.
> {noformat}
> message RegionInTransition {
>   required RegionSpecifier spec = 1;
>   required RegionState region_state = 2;
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message