hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heng Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15829) hbase.client.retries.number has different meanings in branch-1 and master
Date Mon, 16 May 2016 03:05:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284095#comment-15284095
] 

Heng Chen commented on HBASE-15829:
-----------------------------------

Backport HBASE-14521 to branch-1?

> hbase.client.retries.number has different meanings in branch-1 and master
> -------------------------------------------------------------------------
>
>                 Key: HBASE-15829
>                 URL: https://issues.apache.org/jira/browse/HBASE-15829
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Guanghao Zhang
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15829.patch
>
>
> The comment of hbase.client.retries.number is:
> {code}
>   /**  
>    * Parameter name for maximum retries, used as maximum for all retryable
>    * operations such as fetching of the root region from root region server,
>    * getting a cell's value, starting a row update, etc.
>    */
>   public static final String HBASE_CLIENT_RETRIES_NUMBER = "hbase.client.retries.number";
> {code}
> In branch-1, the max attempts number equals with hbase.client.retries.number. But in
master, the max attempts number equals with hbase.client.retries.number + 1.
> For RpcRetryingCaller.
> {code}
> this.retries = retries; // branch-1
> {code}
> {code}
> this.maxAttempts = retries + 1; // master
> {code}
> For AsyncProcess:
> {code}
>     this.numTries = conf.getInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER,
>         HConstants.DEFAULT_HBASE_CLIENT_RETRIES_NUMBER); // branch-1
> {code}
> {code}
>     // how many times we could try in total, one more than retry number
>     this.numTries = conf.getInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER,
>         HConstants.DEFAULT_HBASE_CLIENT_RETRIES_NUMBER) + 1; // master
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message