hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15799) Two Shell 'close_region' Example Syntaxes Don't Work
Date Tue, 10 May 2016 09:06:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277832#comment-15277832
] 

Hudson commented on HBASE-15799:
--------------------------------

FAILURE: Integrated in HBase-Trunk_matrix #911 (See [https://builds.apache.org/job/HBase-Trunk_matrix/911/])
HBASE-15799 Two Shell 'close_region' Example Syntaxes Don't Work (Matt (tedyu: rev 3b74b6f329ad6ebc0d2d2548a7e1290297674529)
* hbase-shell/src/main/ruby/hbase/admin.rb
* hbase-shell/src/test/ruby/hbase/admin_test.rb
* hbase-shell/src/main/ruby/shell/commands/close_region.rb


> Two Shell 'close_region' Example Syntaxes Don't Work
> ----------------------------------------------------
>
>                 Key: HBASE-15799
>                 URL: https://issues.apache.org/jira/browse/HBASE-15799
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 2.0.0
>            Reporter: Matt Warhaftig
>            Assignee: Matt Warhaftig
>            Priority: Minor
>         Attachments: hbase-15799-v1.patch
>
>
> The close_region shell command's help message lists the following usage syntaxes:
> {noformat}
> hbase> close_region 'REGIONNAME'
> hbase> close_region 'REGIONNAME', 'SERVER_NAME'
> hbase> close_region 'ENCODED_REGIONNAME'
> hbase> close_region 'ENCODED_REGIONNAME', 'SERVER_NAME'
> {noformat}
> admin.rb's current code (with close_region method being the entry point) is:
> {code}
> def close_region(region_name, server)
>   if (server == nil || !closeEncodedRegion?(region_name, server))
>     @admin.closeRegion(region_name, server)
>   end
> end
> def closeEncodedRegion?(region_name, server)
>    @admin.closeRegionWithEncodedRegionName(region_name, server)
> end
> {code}
> The {{close_region 'ENCODED_REGIONNAME'}} syntax currently will not work because when
server = nil the {{closeEncodedRegion}} method call is skipped.
> The {{close_region 'REGIONNAME', 'SERVER_NAME'}} syntax currently will not work because
{{@admin.closeRegionWithEncodedRegionName}} throws an NotServingRegionException (for the non-encoded
region_name) that is uncaught in and prevents execution from returning to {{close_region}}
and the correct call of {{HBaseAdmin.closeRegion}}. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message