hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15795) Cleanup all classes in package org.apache.hadoop.hbase.ipc for code style
Date Tue, 10 May 2016 05:52:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277657#comment-15277657
] 

Hudson commented on HBASE-15795:
--------------------------------

FAILURE: Integrated in HBase-Trunk_matrix #910 (See [https://builds.apache.org/job/HBase-Trunk_matrix/910/])
HBASE-15797 TestIPCUtil fails after HBASE-15795 (stack: rev 9d17e3d22a03dbff99b67837184bfe731049d56f)
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/IPCUtil.java


> Cleanup all classes in package org.apache.hadoop.hbase.ipc for code style
> -------------------------------------------------------------------------
>
>                 Key: HBASE-15795
>                 URL: https://issues.apache.org/jira/browse/HBASE-15795
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15795.patch
>
>
> While making adjustments for the async client I also need to fix code styling on the
relevant classes. I want to do it all at once for ipc package so it does not mess up the diffs
of future changes. I left out the classes I already fixed in patch in HBASE-15793
> * Fixed import order
> * Added curly brackets to all one line if statements
> * Simplified generics with diamond operators where applicable
> * Made private fields final when they were able
> * use try with resource where it could be used
> * renamed variables which were obscuring class fields
> * Added documentation to empty @ doc fields
> * Removed unnecessary setting to null 
> * Removed unused getDelimitedMessageAsByteBuffer and readChunked methods from private
IPCUtil class



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message