hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15795) Cleanup all classes in package org.apache.hadoop.hbase.ipc for code style
Date Sat, 07 May 2016 18:06:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275330#comment-15275330
] 

Hudson commented on HBASE-15795:
--------------------------------

FAILURE: Integrated in HBase-Trunk_matrix #903 (See [https://builds.apache.org/job/HBase-Trunk_matrix/903/])
HBASE-15795 Cleanup all classes in package org.apache.hadoop.hbase.ipc (stack: rev e71ae601f7ce40c7f917141ff7a4122f6205987b)
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorRpcUtils.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/IPCUtil.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/MasterCoprocessorRpcChannel.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CallTimeoutException.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcController.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/ConnectionId.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionServerCoprocessorRpcChannel.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientFactory.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncServerResponseHandler.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcCallback.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/Call.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/FailedServers.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DelegatingPayloadCarryingRpcController.java


> Cleanup all classes in package org.apache.hadoop.hbase.ipc for code style
> -------------------------------------------------------------------------
>
>                 Key: HBASE-15795
>                 URL: https://issues.apache.org/jira/browse/HBASE-15795
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15795.patch
>
>
> While making adjustments for the async client I also need to fix code styling on the
relevant classes. I want to do it all at once for ipc package so it does not mess up the diffs
of future changes. I left out the classes I already fixed in patch in HBASE-15793
> * Fixed import order
> * Added curly brackets to all one line if statements
> * Simplified generics with diamond operators where applicable
> * Made private fields final when they were able
> * use try with resource where it could be used
> * renamed variables which were obscuring class fields
> * Added documentation to empty @ doc fields
> * Removed unnecessary setting to null 
> * Removed unused getDelimitedMessageAsByteBuffer and readChunked methods from private
IPCUtil class



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message