hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HBASE-15795) Cleanup all classes in package org.apache.hadoop.hbase.ipc for code style
Date Sat, 07 May 2016 17:04:12 GMT

     [ https://issues.apache.org/jira/browse/HBASE-15795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack resolved HBASE-15795.
---------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 2.0.0

Pushed to master branch. Thanks [~jurmous]

> Cleanup all classes in package org.apache.hadoop.hbase.ipc for code style
> -------------------------------------------------------------------------
>
>                 Key: HBASE-15795
>                 URL: https://issues.apache.org/jira/browse/HBASE-15795
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15795.patch
>
>
> While making adjustments for the async client I also need to fix code styling on the
relevant classes. I want to do it all at once for ipc package so it does not mess up the diffs
of future changes. I left out the classes I already fixed in patch in HBASE-15793
> * Fixed import order
> * Added curly brackets to all one line if statements
> * Simplified generics with diamond operators where applicable
> * Made private fields final when they were able
> * use try with resource where it could be used
> * renamed variables which were obscuring class fields
> * Added documentation to empty @ doc fields
> * Removed unnecessary setting to null 
> * Removed unused getDelimitedMessageAsByteBuffer and readChunked methods from private
IPCUtil class



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message