hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
Date Mon, 09 May 2016 23:43:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277344#comment-15277344
] 

Hudson commented on HBASE-15740:
--------------------------------

SUCCESS: Integrated in HBase-1.4 #144 (See [https://builds.apache.org/job/HBase-1.4/144/])
HBASE-15740 Replication source.shippedKBs metric is undercounting (enis: rev d07d31611395ae4e0befc04a0b8cc67adcacacb9)
* hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java
* hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java
* hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
* hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java


> Replication source.shippedKBs metric is undercounting because it is in KB
> -------------------------------------------------------------------------
>
>                 Key: HBASE-15740
>                 URL: https://issues.apache.org/jira/browse/HBASE-15740
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0, 1.3.0, 1.4.0
>
>         Attachments: hbase-15740_v1.patch, hbase-15740_v2.patch
>
>
> In a cluster where there is replication going on, I've noticed that this is always 0:
> {code}
>     "source.shippedKBs" : 0,
> {code}
> Looking at the source reveals why:
> {code}
>           metrics.shipBatch(currentNbOperations, currentSize / 1024, currentNbHFiles);
> {code}
> It is always undercounting because we discard remaining bytes after KB boundary. This
is specially a problem when we are always shipping small batches <1KB.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message