hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15735) Tightening of the CP contract
Date Mon, 02 May 2016 08:23:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266220#comment-15266220
] 

Hudson commented on HBASE-15735:
--------------------------------

FAILURE: Integrated in HBase-Trunk_matrix #885 (See [https://builds.apache.org/job/HBase-Trunk_matrix/885/])
HBASE-15735 Tightening of the CP contract. (anoopsamjohn: rev d1130582d54ca78bbd708c39e4fa02e7b89b232e)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedRegionScannerImpl.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerFromBucketCache.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/ShareableMemory.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java


> Tightening of the CP contract 
> ------------------------------
>
>                 Key: HBASE-15735
>                 URL: https://issues.apache.org/jira/browse/HBASE-15735
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15735.patch, HBASE-15735.patch
>
>
> This is after the discussion in dev@ under 'DISCUSSION: A tightening of the CP contract
in hbase 2.0.0'
> "CPs can read Cells passed them on a CP hook invocation but
> they must not retain references beyond the life of the invocation; they
> must copy Cells if they intend to retain them beyond the invocation, pass
> the Cells off to upper tiers, or return them otherwise to clients."
> Also this Jira will cleanup some code which was doing the copy of the Cells while passing
to CP hooks assuming it might keep cell refs. Now as we say it explicitly in CP APIs,  we
dont need this copy.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message