hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15698) Increment TimeRange not serialized to server
Date Fri, 27 May 2016 23:00:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304957#comment-15304957
] 

Anoop Sam John commented on HBASE-15698:
----------------------------------------

Code change looks good. 
bq.import org.mortbay.log.Log;
Unused import. Pls remove

Regarding new test, do we need the CP?  For assert fine np.  There is an unused Dummy CP.
Pls remove.  Assert for TR reached CP, pls add assert for increment when we have Increment.setTimerange.

Just checked all other mutations.  Seems only Increment is having this kind of extra attribute
which we missed pbing when using PB convert with no cell data.

> Increment TimeRange not serialized to server
> --------------------------------------------
>
>                 Key: HBASE-15698
>                 URL: https://issues.apache.org/jira/browse/HBASE-15698
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: James Taylor
>            Assignee: Sean Busbey
>            Priority: Blocker
>              Labels: phoenix
>             Fix For: 1.3.0, 1.0.4, 1.2.2, 0.98.20, 1.1.6
>
>         Attachments: 15698-suggest.txt, 15698.v1.txt, HBASE-15698.1.patch
>
>
> Before HBase-1.2, the Increment TimeRange set on the client was serialized over to the
server. As of HBase 1.2, this appears to no longer be true, as my preIncrement coprocessor
always gets HConstants.LATEST_TIMESTAMP as the value of increment.getTimeRange().getMax()
regardless of what the client has specified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message