hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guanghao Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15615) Wrong sleep time when RegionServerCallable need retry
Date Sat, 07 May 2016 05:25:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275096#comment-15275096
] 

Guanghao Zhang commented on HBASE-15615:
----------------------------------------

When working with this issue, I found that hbase.client.retries.number has different meanings
in branch-1 and master. In branch-1, the max attempts number equals with hbase.client.retries.number.
But in master, the max attempts number equals with  hbase.client.retries.number + 1. I am
not sure which one is right.

The comment of hbase.client.retries.number is:
{code}
  /**  
   * Parameter name for maximum retries, used as maximum for all retryable
   * operations such as fetching of the root region from root region server,
   * getting a cell's value, starting a row update, etc.
   */
  public static final String HBASE_CLIENT_RETRIES_NUMBER = "hbase.client.retries.number";
{code}

> Wrong sleep time when RegionServerCallable need retry
> -----------------------------------------------------
>
>                 Key: HBASE-15615
>                 URL: https://issues.apache.org/jira/browse/HBASE-15615
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.0.0, 2.0.0, 1.1.0, 1.2.0, 1.3.0
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>             Fix For: 1.3.0
>
>         Attachments: HBASE-15615-branch-1.0-v2.patch, HBASE-15615-branch-1.1-v2.patch,
HBASE-15615-branch-1.patch, HBASE-15615-v1.patch, HBASE-15615-v1.patch, HBASE-15615-v2.patch,
HBASE-15615.patch
>
>
> In RpcRetryingCallerImpl, it get pause time by expectedSleep = callable.sleep(pause,
tries + 1); And in RegionServerCallable, it get pasue time by sleep = ConnectionUtils.getPauseTime(pause,
tries + 1). So tries will be bumped up twice. And the pasue time is 3 * hbase.client.pause
when tries is 0.
> RETRY_BACKOFF = {1, 2, 3, 5, 10, 20, 40, 100, 100, 100, 100, 200, 200}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message