hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15593) Time limit of scanning should be offered by client
Date Tue, 17 May 2016 15:07:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286797#comment-15286797
] 

Phil Yang commented on HBASE-15593:
-----------------------------------

{quote}
This check looks weird?
{quote}
call.rpcTimeout  is a Long and if it is greater than  Integer.MAX_VALUE, (int)call.rpcTimeout
will be negative.

The conf minClientRequestTimeout is like minimumScanTimeLimitDelta = rs.conf.getLong(REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA,
DEFAULT_REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA) in RSRpcServices. The rpc timeout
is in all requests' header, so I think we need a new conf here.

> Time limit of scanning should be offered by client
> --------------------------------------------------
>
>                 Key: HBASE-15593
>                 URL: https://issues.apache.org/jira/browse/HBASE-15593
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 1.1.4
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.2, 1.1.6
>
>         Attachments: HBASE-15593-branch-1-v1.patch, HBASE-15593-branch-1-v2.patch, HBASE-15593-branch-1-v3.patch,
HBASE-15593-branch-1.1-v1.patch, HBASE-15593-branch-1.1-v2.patch, HBASE-15593-branch-1.1-v3.patch,
HBASE-15593-branch-1.2-v1.patch, HBASE-15593-branch-1.2-v2.patch, HBASE-15593-branch-1.2-v3.patch,
HBASE-15593-v1.patch, HBASE-15593-v2.patch, HBASE-15593-v3.patch, HBASE-15593-v4.patch, HBASE-15593-v5.patch,
HBASE-15593-v6.patch, HBASE-15593-v7.patch
>
>
> In RSRpcServices.scan, we will set a time limit equaling to Math.min(scannerLeaseTimeoutPeriod,
rpcTimeout) / 2, and will response heartbeat message if we reach this limit. However, two
timeout settings (hbase.client.scanner.timeout.period and hbase.rpc.timeout) are read from
RS's configure, which may be different from client's. If client's setting is much less than
server's, there may still be timeout at client side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message