hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15575) Rename table DDL *Handler methods in MasterObserver to more meaningful names
Date Thu, 05 May 2016 06:47:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271975#comment-15271975
] 

Hadoop QA commented on HBASE-15575:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 6 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 38s {color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 7s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s {color} | {color:green}
master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s {color} |
{color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 8m 45s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 30s {color}
| {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 30s {color} | {color:red}
hbase-rsgroup in master has 7 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 46s {color} |
{color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s {color} |
{color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s {color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 58s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s {color} |
{color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s {color} |
{color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 46s {color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 46s {color} | {color:red}
hbase-server: patch generated 25 new + 590 unchanged - 62 fixed = 615 total (was 652) {color}
|
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 3m 55s {color} | {color:red}
hbase-rsgroup: patch generated 25 new + 590 unchanged - 62 fixed = 615 total (was 652) {color}
|
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 29s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 8m 31s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 55s {color} |
{color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 31s {color} | {color:red}
hbase-server-jdk1.8.0 with JDK v1.8.0 generated 1 new + 1 unchanged - 0 fixed = 2 total (was
1) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 46s {color} |
{color:green} the patch passed with JDK v1.8.0 {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 2m 15s {color} | {color:red}
hbase-server-jdk1.7.0_79 with JDK v1.7.0_79 generated 1 new + 1 unchanged - 0 fixed = 2 total
(was 1) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s {color} |
{color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 102m 17s {color} | {color:green}
hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 27s {color} | {color:green}
hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 27s {color}
| {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 147m 33s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12802357/HBASE-15575.v4-master.patch
|
| JIRA Issue | HBASE-15575 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  |
| uname | Linux pietas.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh
|
| git revision | master / d23d600 |
| Default Java | 1.7.0_79 |
| Multi-JDK versions |  /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79
|
| findbugs | v3.0.0 |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/1773/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html
|
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/1773/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/1773/artifact/patchprocess/diff-checkstyle-hbase-rsgroup.txt
|
| javadoc | hbase-server-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/1773/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.8.0.txt
|
| javadoc | hbase-server-jdk1.7.0_79: https://builds.apache.org/job/PreCommit-HBASE-Build/1773/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.7.0_79.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/1773/testReport/ |
| modules | C: hbase-server hbase-rsgroup U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1773/console |
| Powered by | Apache Yetus 0.2.1   http://yetus.apache.org |


This message was automatically generated.



> Rename table DDL *Handler methods in MasterObserver to more meaningful names
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-15575
>                 URL: https://issues.apache.org/jira/browse/HBASE-15575
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>    Affects Versions: 2.0.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15575.v1-master.patch, HBASE-15575.v2-master.patch, HBASE-15575.v3-master.patch,
HBASE-15575.v4-master.patch
>
>
> Procedure V2 replaced table DDL handler implementation to procedure implementation. 
It does not make sense to keep the *Handler methods in MasterObserver.  This JIRA follows
HBASE-13645 way to deprecate the existing observers with *Handler and add the new observers
with more meaningful names.  
> One proposal that to rename the coprocessor in procedure thread with Action and use Completed/Rollback
to distinguish successful or failed procedures.  (Note: this JIRA is just for name change;
the actual Rollback cp does not exist today) 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message