hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15563) 'counter' may overflow in BoundedGroupingStrategy
Date Thu, 05 May 2016 19:14:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272894#comment-15272894
] 

Hudson commented on HBASE-15563:
--------------------------------

SUCCESS: Integrated in HBase-1.3-IT #649 (See [https://builds.apache.org/job/HBase-1.3-IT/649/])
HBASE-15563 'counter' may overflow in BoundedGroupingStrategy (Matt (tedyu: rev 5c3a18e76e7e20492929df48c5b9c8376ab6af25)
* hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedGroupingStrategy.java


> 'counter' may overflow in BoundedGroupingStrategy
> -------------------------------------------------
>
>                 Key: HBASE-15563
>                 URL: https://issues.apache.org/jira/browse/HBASE-15563
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Duo Zhang
>            Assignee: Matt Warhaftig
>            Priority: Minor
>              Labels: beginner
>             Fix For: 2.0.0, 1.3.0, 1.4.0
>
>         Attachments: hbase-15563-v1.patch, hbase-15563-v2.patch
>
>
> {code}
> groupName = groupNames[counter.getAndIncrement() % groupNames.length];
> {code}
> Theoretically, counter can overflow and becomes negative then causes an ArrayIndexOutOfBoundsException.
> But in practice, we need 2 billions different identifiers to make this happen, and before
the overflow we will run into OOM because of a huge groupNameCache...
> So not sure if it is worth to fix



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message