Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 29 Apr 2016 17:45:12 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12963778.1461914999000.72057.1461951912918@Atlassian.JIRA>
In-Reply-To: <JIRA.12963778.1461914999000@Atlassian.JIRA>
References: <JIRA.12963778.1461914999000@Atlassian.JIRA>
 <JIRA.12963778.1461914999414@arcas>
Subject: [jira] [Commented] (HBASE-15735) Tightening of the CP contract
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-15735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264414#comment-15264414 ] 

Ted Yu commented on HBASE-15735:
--------------------------------

lgtm

> Tightening of the CP contract 
> ------------------------------
>
>                 Key: HBASE-15735
>                 URL: https://issues.apache.org/jira/browse/HBASE-15735
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15735.patch, HBASE-15735.patch
>
>
> This is after the discussion in dev@ under 'DISCUSSION: A tightening of the CP contract in hbase 2.0.0'
> "CPs can read Cells passed them on a CP hook invocation but
> they must not retain references beyond the life of the invocation; they
> must copy Cells if they intend to retain them beyond the invocation, pass
> the Cells off to upper tiers, or return them otherwise to clients."
> Also this Jira will cleanup some code which was doing the copy of the Cells while passing to CP hooks assuming it might keep cell refs. Now as we say it explicitly in CP APIs,  we dont need this copy.  


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)