Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C9E2A19269 for ; Sun, 24 Apr 2016 03:15:13 +0000 (UTC) Received: (qmail 15926 invoked by uid 500); 24 Apr 2016 03:15:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 15820 invoked by uid 500); 24 Apr 2016 03:15:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 15698 invoked by uid 99); 24 Apr 2016 03:15:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Apr 2016 03:15:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 057A32C1F64 for ; Sun, 24 Apr 2016 03:15:13 +0000 (UTC) Date: Sun, 24 Apr 2016 03:15:13 +0000 (UTC) From: "Duo Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15693) Reconsider the ImportOrder rule of checkstyle MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-15693: ------------------------------ Attachment: HBASE-15693-branch-1.3.patch > Reconsider the ImportOrder rule of checkstyle > --------------------------------------------- > > Key: HBASE-15693 > URL: https://issues.apache.org/jira/browse/HBASE-15693 > Project: HBase > Issue Type: Bug > Components: build > Reporter: Duo Zhang > Assignee: Duo Zhang > Labels: checkstyle > Attachments: HBASE-15693-branch-1.1.patch, HBASE-15693-branch-1.2.patch, HBASE-15693-branch-1.3.patch, HBASE-15693-branch-1.patch, HBASE-15693.patch > > > I have been confused many times with the wrong import order checkstyle warnings in the pre commit result. And I haven't found any developer guide which tells me what is the right order so this time I decided to read the rule by myself. > In the ImportOrder section, we declare sortStaticImportsAlphabetically which can only work with option 'top' or 'bottom'(which means place static imports on top or bottom) and use the default option which is 'under'. > I prefer placing static import on top, so I suggest here we set option to 'top'. -- This message was sent by Atlassian JIRA (v6.3.4#6332)